is-checked and group for menus
#1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wixoaGit
requested changes
Sep 27, 2023
Co-authored-by: wixoa <[email protected]>
wixoaGit
approved these changes
Sep 27, 2023
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles checking and group checking for menu items.
Note we need to fix a bug in RT upstream, because right now closing a submenu doesn't close it's parent, and so updates aren't reflected in the menu until the menu is fully closed. I'll PR something upstream in a bit but also RT is making some major changes right now so that might be a bit of a thing.
I added property getting also, although property setting is not implemented. The only notable thing to do there would be to call
CreateMenu()after one of the element descriptors was updated.